Simplify mode flags #116
Merged
Simplify mode flags #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rename `*Flag::to_char` and `MembershipFlagFlag::to_prefix` to `MembershipFlagFlag::mode_char` and `MembershipFlagFlag::prefix_char`, because the prefix is also a char 2. Remove `*Set::char_for` and `MembershipFlagSet::prefix_for`, they are less efficient duplicates of the above 3. Move `*Set::flag_for` and `MembershipFlagSet::flag_for_prefix` to `*Flag::from_mode_char` and `MembershipFlagFlag::from_prefix_char` because they don't belong on a set and "flag_for" is an unclear name 4. Remove chars from `ALL` and `all()` because they are not needed anymore 5. Removed parser support for specifying extra chars that would be ignored
|
actually I just added it to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Flag::to_charandMembershipFlagFlag::to_prefixtoMembershipFlagFlag::mode_charandMembershipFlagFlag::prefix_char, because the prefix is also a char*Set::char_forandMembershipFlagSet::prefix_for, they are less efficient duplicates of the above*Set::flag_forandMembershipFlagSet::flag_for_prefixto*Flag::from_mode_charandMembershipFlagFlag::from_prefix_charbecause they don't belong on a set and "flag_for" is an unclear nameALLandall()because they are not needed anymore