Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
sable_history
crate defines aHistoryService
trait, which could be implemented in various ways:NetworkHistoryLog
that every node hasFor now, only item 1 is implemented, by moving the backend implementation of the
CHATHISTORY
command handler tosable_history
.The "hypothetical dedicated node" will probably be implemented by
sable_history
itself, and it will also benefit from theHistoryService
, which will allow it to support multiple database backends, so we can more easily prototype and compare them.