Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LINKS command #148

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Add LINKS command #148

merged 1 commit into from
Dec 8, 2024

Conversation

progval
Copy link
Collaborator

@progval progval commented Dec 8, 2024

This will be used by irctest to wait for sable_history to be up and reachable.

Other servers print a "description" from the configuration. But I'm guessing you aren't interested in adding that to the config, so I made it print some other info instead.

This will be used by irctest to wait for sable_history to be up and reachable
@spb
Copy link
Collaborator

spb commented Dec 8, 2024

I don't think this is the right way to approach the policy side. Long term, LINKS is an oper/management command, not a debugging one, so it belongs in that policy service. Long term the policy should also be configurable at runtime so that irctest can just specify an 'allow everything' policy for debug purposes, but that's quite a lot more work. I think for now the more sensible stepping stone is to put it in the oper policy service but always allow it, with a big 'TODO' label to address that down the road.

@progval
Copy link
Collaborator Author

progval commented Dec 8, 2024

I don't see it as an oper command because every other IRCd allows it for non-opers

@spb
Copy link
Collaborator

spb commented Dec 8, 2024

...and actually it's not a big deal either way if we're going to re-do the policy framework later anyway.

@spb spb merged commit 034c4d5 into Libera-Chat:master Dec 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants