Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

02-match-extract-strings: Fix solution and typos in Finish the expression #196

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

ldko
Copy link
Contributor

@ldko ldko commented Dec 15, 2021

This PR is to fix the solution and typos in the Finish the expression challenge. At some point the last + was removed from the solution. Also, there is no need to put the \w after the literal . in square brackets since it is only one option.

As a side note, in challenges where you give hints, you could do them as dropdowns to give people a chance to solve the challenge without them e.g.:

> > ## Hint
> > The `.` is also a metacharacter, so you will have to use the escape `\`
> > to express a literal period.

hint_dropdown

I did not include the Hint as a dropdown in this PR, since that is not how you are doing hints generally.

@LRDamsma
Copy link

LRDamsma commented Oct 7, 2022

This is almost a year old now. Who can fix this?

@ostephens
Copy link

Generally I'd hope one of the maintainers could look at it @sharilaster @ppival @antonangelo @ccronje
If they aren't able to then I'm able to merge (none of the changes here look likely to be a problem to me) it but generally I'd hope a maintainer could at least take a look before that happens

@sharilaster
Copy link
Contributor

Hi @LRDamsma and @ostephens, sorry I overlooked this request when it first came in. I think the suggestion from @ldko to improve hints should be submitted as an issue; if others concur, then once that is done I can merge and close this PR.

@ostephens
Copy link

Thanks @sharilaster.

I think the suggestion from @ldko to improve hints should be submitted as an issue; if others concur, then once that is done I can merge and close this PR.

I agree that needs to be a separate issue, but I don't think that needs to hold up merging and closing this PR? (as this PR uses the current approach to hints)

@sharilaster
Copy link
Contributor

I agree that needs to be a separate issue, but I don't think that needs to hold up merging and closing this PR? (as this PR uses the current approach to hints)

@ostephens I just want to make sure it isn't lost as a suggestion. I am not sure if other maintainers are still monitoring this lesson, but I can wait a day or so to see if others weigh in, and then merge/close at that point. Would that work?

@ostephens
Copy link

Sure! I've created an issue for that now #200

@sharilaster
Copy link
Contributor

That looks great, thank you so much @ostephens! And thank you @ldko for the suggestion and @LRDamsma for the nudge to address this PR.

@sharilaster sharilaster merged commit f9a6213 into LibraryCarpentry:gh-pages Oct 7, 2022
zkamvar pushed a commit that referenced this pull request May 3, 2023
02-match-extract-strings: Fix solution and typos in Finish the expression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants