Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Encapsulate multiprocessing communication #419

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

[wip] Encapsulate multiprocessing communication #419

wants to merge 10 commits into from

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jan 20, 2025 •
edited
Loading

What does this PR do?

  • Single interface for both ZMQ and multiprocessing queue for communication.
  • Either of them can be just replaced without any internal detail and without using if...else check for the type of communication.
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya marked this pull request as draft January 21, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@Andrei-Aksionov Andrei-Aksionov Awaiting requested review from Andrei-Aksionov

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aniketmaurya