Fix: Bug: SRFI 1 fold and fold-right #190 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I'm not very familiar with variant parameters; please check them. I added two simple cases provided by the srfi-1 about the cons. As I didn't find an "unpack", I use "apply" to represent.
da-liii
reviewed
Dec 31, 2024
| initial | ||
| (cdr l))))) | ||
| (define (fold f accum . lsts) | ||
| (if (eq? 1 (length lsts)) |
There was a problem hiding this comment.
保留一下type-error，现在的syntax-error报错在内部，无法有效判断具体的错误原因
There was a problem hiding this comment.
length的时间复杂度为O(n)，通过length判断判断列表长度是否为1，时间复杂度过高
There was a problem hiding this comment.
|
I suggest add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implement the fold, fold-right for variant parameters. I added two simple cases provided by the srfi-1 about the cons. As I didn't find an "unpack", I use "apply" to represent. As I'm not very familiar with variant parameters, please check them.
@Ancker-0 @da-liii