move from marky-markdown to marked #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed unused dependencies
davidrapin
changed the title
|
@yigitakbulut code review welcome, if you have some spare time. No rush. |
| debug: false, // console.log() all the things | ||
| package: null // npm package metadata | ||
| }); | ||
| return marked(markdown); |
There was a problem hiding this comment.
Question, what about the removed options for marky, are we sure marked handles them properly?
Highlighting for sure handled by hl.js, what about the others?
There was a problem hiding this comment.
yes, we could add a comment to marked's default config values, which match our needs: https://marked.js.org/using_advanced#options
| const renderer = { | ||
| heading(text, level) { | ||
| const escapedText = text.toLowerCase().replace(/[^\w]+/g, '-'); | ||
| return '<h' + level + ' class="header"><a aria-hidden="true" id="' + |
There was a problem hiding this comment.
Could you explain why this change?
There was a problem hiding this comment.
This generates anchor links next to each h1/h2/h3 title.
The previous library did this automatically, this one needs a little hack.
|
@yigitakbulut I added comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4