Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update setup relayer node guide and Chain Connector API page #1945

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Update setup relayer node guide and Chain Connector API page #1945

merged 5 commits into from
Mar 26, 2024

Conversation

TalhaMaliktz
Copy link
Contributor

Resolves #1944

@TalhaMaliktz TalhaMaliktz self-assigned this Mar 21, 2024
@TalhaMaliktz TalhaMaliktz added component: lisk Lisk documentation type: update Existing content, that needs to be updated type: improvement Improve existing content labels Mar 21, 2024
@TalhaMaliktz TalhaMaliktz marked this pull request as ready for review March 21, 2024 17:43
ishantiw
ishantiw suggested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks nice, just a few comments on adding some more information and references.

docs/modules/ROOT/pages/run-blockchain/setup-relayer.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/run-blockchain/setup-relayer.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/run-blockchain/setup-relayer.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/run-blockchain/setup-relayer.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/run-blockchain/setup-relayer.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/run-blockchain/setup-relayer.adoc Show resolved Hide resolved
@TalhaMaliktz @ishantiw
Apply suggestions from Ishan's review
da5267e 
Co-authored-by: !shan <ishantiw.quasar@gmail.com>
@TalhaMaliktz TalhaMaliktz requested a review from ishantiw March 22, 2024 12:21
Tschakki
Tschakki approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@Tschakki Tschakki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ishantiw
ishantiw approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👏

@Tschakki Tschakki merged commit aa55c0a into development Mar 26, 2024
@Tschakki Tschakki deleted the 1944-update-setup-relayer-node-guide branch March 26, 2024 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ishantiw ishantiw ishantiw approved these changes

@Tschakki Tschakki Tschakki approved these changes

Assignees

@TalhaMaliktz TalhaMaliktz

Labels
component: lisk Lisk documentation type: improvement Improve existing content type: update Existing content, that needs to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Setup Relayer node guide
3 participants
@TalhaMaliktz @Tschakki @ishantiw