Add length check to getLisk32AddressFromPublicKey

LiskArchive · Oct 26, 2023 · 31a1073 · 31a1073
1 parent 185e3fa
commit 31a1073
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/elements/lisk-cryptography/src/address.ts b/elements/lisk-cryptography/src/address.ts
@@ -118,7 +118,12 @@ const addressToLisk32 = (address: Buffer): string => {
 export const getLisk32AddressFromPublicKey = (
 	publicKey: Buffer,
 	prefix = DEFAULT_LISK32_ADDRESS_PREFIX,
-): string => `${prefix}${addressToLisk32(getAddressFromPublicKey(publicKey))}`;
+): string => {
+	if (publicKey.length !== 32) {
+		throw new Error('publicKey length must be 32.');
+	}
+	return `${prefix}${addressToLisk32(getAddressFromPublicKey(publicKey))}`;
+};
 
 export const validateLisk32Address = (
 	address: string,

diff --git a/elements/lisk-cryptography/test/address.spec.ts b/elements/lisk-cryptography/test/address.spec.ts
@@ -57,6 +57,12 @@ describe('address', () => {
 	});
 
 	describe('#getLisk32AddressFromPublicKey', () => {
+		it('should reject when publicKey length is not 32', () => {
+			expect(() => getLisk32AddressFromPublicKey(Buffer.alloc(31), 'lsk')).toThrow(
+				'publicKey length must be 32.',
+			);
+		});
+
 		it('should generate lisk32 address from publicKey', () => {
 			const address = getLisk32AddressFromPublicKey(defaultPublicKey, 'lsk');