_verifyTerminatedStateAccountsCommon doesn't need to be inside loop

[sitetester]

What was the problem?

This PR resolves #8998

How was it solved?

Bug fixed & genesis block updated

Steps to update genesis block:

• cd lisk-sdk/examples/interop/pos-mainchain-fast
• ./bin/run genesis-block:create --output config/default/ --assets-file config/default/genesis_assets.json
• ./bin/run start --api-ipc --api-http --port 9001

Debugging tips:

• To remove existing app rm -rf ~/.lisk/pos-mainchain-fast
• To allow HTTP communication (via, e.g., postman)

nano ~/.lisk/pos-mainchain-fast/config/config.json
"rpc": {
        "modes": ["ipc", "ws", "http"],
        "allowedMethods": ["*"]
},

How was it tested?

Relevant test added

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (release/6.0.0@6fc44ea). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 0ba0c9e differs from pull request most recent head 483bb95. Consider uploading reports for the commit 483bb95 to get more accurate results

@@               Coverage Diff                @@
##             release/6.0.0    #9079   +/-   ##
================================================
  Coverage                 ?   83.46%           
================================================
  Files                    ?      604           
  Lines                    ?    22796           
  Branches                 ?     3365           
================================================
  Hits                     ?    19027           
  Misses                   ?     3769           
  Partials                 ?        0           

Files	Coverage Δ
...s/interoperability/base_interoperability_module.ts	99.21% <100.00%> (ø)
...k/src/modules/interoperability/mainchain/module.ts	93.49% <100.00%> (ø)
...k/src/modules/interoperability/sidechain/module.ts	95.32% <100.00%> (ø)

[ishantiw]

Looks good,

• I think we need to pass ownChainID i.e.,

const mainchainID = getMainchainID(ctx.chainID);

https://github.com/LiskHQ/lisk-sdk/blob/c9c1ecc7f71b41edabb2919ced2c7c51f3192a04/framework/src/modules/interoperability/sidechain/module.ts#L293

Another small change,

• https://github.com/LiskHQ/lisk-sdk/blob/c9c1ecc7f71b41edabb2919ced2c7c51f3192a04/framework/src/modules/interoperability/base_interoperability_module.ts#L149-L152 use BigInt(0) for comparison

Please include it in the same PR

[ishantiw]

Overall looks fine to me,
One issue, the comparison should be ownChainNonce <= BigInt(0)
https://github.com/LiskHQ/lisk-sdk/blob/24cdc25d44b35c9c406079c7c8d795bb571bd5e6/framework/src/modules/interoperability/mainchain/module.ts#L268C41-L268C54

[gkoumout]

Very nice, good job! Approved, with an optional small improvement suggestion.

[gkoumout]

Looks good to me!

[ishantiw]

Good work @sitetester 👏