This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #9094
How was it solved?
Changed
transaction:sign
command to no longer hardcode private key derivation to legacy method. Now it usesderiveKeypair()
function which will use either legacy or key path derivation, depending on the provided--key-derivation-path
flags.How was it tested?
When signing a multisig transactions offline, every signing from a different multisig signer now adds an additional signature to transaction's
signatures
array.