Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Adds test for getPrivateKeyFromPhraseAndPath #9096

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

has5aan
Copy link
Contributor

@has5aan has5aan commented Oct 17, 2023

What was the problem?

This PR resolves #8104

How was it solved?

Adds a test case validating generation of distinct private key using similar passphrase but distinct paths.

How was it tested?

release/6.1.0

@has5aan has5aan requested review from shuse2 and vjaiman October 17, 2023 08:37
@has5aan has5aan self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #9096 (f31b506) into release/6.1.0 (f79aa30) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.1.0    #9096   +/-   ##
==============================================
  Coverage          84.34%   84.34%           
==============================================
  Files                652      652           
  Lines              23967    23967           
  Branches            3489     3489           
==============================================
  Hits               20216    20216           
  Misses              3751     3751           

Copy link

@vjaiman vjaiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@shuse2 shuse2 merged commit 9747cce into release/6.1.0 Oct 18, 2023
@shuse2 shuse2 deleted the 8104-unit-tests branch October 18, 2023 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants