-
Notifications
You must be signed in to change notification settings - Fork 458
Add length check to getLisk32AddressFromPublicKey #9124
Conversation
Codecov Report
@@ Coverage Diff @@
## release/6.1.0 #9124 +/- ##
==============================================
Coverage 84.34% 84.35%
==============================================
Files 652 652
Lines 23966 23970 +4
Branches 3489 3490 +1
==============================================
+ Hits 20215 20219 +4
Misses 3751 3751
|
In lisk-sdk, |
Each package should be independent of SDK, hence each package should have it's own constant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elements/lisk-cryptography/test/address.spec.ts
Currently, there are describe
blocks starting with #
. For future PRs, this practice should be discouraged, as there is no such standard
What was the problem?
This PR resolves #9083
How was it solved?
Added length check to getLisk32AddressFromPublicKey
How was it tested?
Unit test updated