This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/6.1.0 #9126 +/- ##
=================================================
+ Coverage 84.35% 84.39% +0.04%
=================================================
Files 652 652
Lines 23970 23964 -6
Branches 3490 3488 -2
=================================================
+ Hits 20219 20224 +5
+ Misses 3751 3740 -11
|
AndreasKendziorra
suggested changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left an additional comment in issue #8115
…or already has valid BLS key.
…eenTimestamps. Co-authored-by: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
AndreasKendziorra
approved these changes
Oct 30, 2023
shuse2
reviewed
Nov 1, 2023
shuse2
approved these changes
Nov 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves issue #8115 & issue #7267 Some points in the issue, potentially requiring no change are responded to in a comment on the issue.
How was it solved?
Adds and updates tests for
ValidatorsMethod
.How was it tested?
All tests are passing.