Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Blockchain:hash returns incorrect hash #9150

Merged
merged 6 commits into from
Nov 24, 2023
Merged

Blockchain:hash returns incorrect hash #9150

merged 6 commits into from
Nov 24, 2023

Conversation

Incede
Copy link
Contributor

@Incede Incede commented Nov 23, 2023

What was the problem?

This PR resolves #9148

How was it solved?

Fixed incorrect read of database stream

How was it tested?

Under examples app pos-mainchain
./bin/run blockchain hash -d ~/.lisk/pos-mainchain

@Incede Incede requested review from shuse2 and ishantiw November 23, 2023 12:14
@Incede Incede self-assigned this Nov 23, 2023
@shuse2 shuse2 changed the base branch from release/6.0.0 to hotfix/6.0.1 November 23, 2023 12:36
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #9150 (5c025f0) into hotfix/6.0.1 (f825978) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           hotfix/6.0.1    #9150   +/-   ##
=============================================
  Coverage         83.51%   83.52%           
=============================================
  Files               606      606           
  Lines             22826    22827    +1     
  Branches           3364     3364           
=============================================
+ Hits              19064    19066    +2     
+ Misses             3762     3761    -1     
Files Coverage Δ
...nder/src/bootstrapping/commands/blockchain/hash.ts 94.28% <100.00%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we test this on mainnet data? I think we might need to chunk the data for whole db iteration

@Incede
Copy link
Contributor Author

Incede commented Nov 24, 2023

did we test this on mainnet data? I think we might need to chunk the data for whole db iteration

With the mainnet data here it takes ~2mins16sec on macOs M1 to complete and produce the output hash.

@Incede Incede requested a review from shuse2 November 24, 2023 08:35
@shuse2 shuse2 merged commit c610d8c into hotfix/6.0.1 Nov 24, 2023
10 checks passed
@shuse2 shuse2 deleted the 9148-hash branch November 24, 2023 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants