This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Blockchain:hash returns incorrect hash #9150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## hotfix/6.0.1 #9150 +/- ##
=============================================
Coverage 83.51% 83.52%
=============================================
Files 606 606
Lines 22826 22827 +1
Branches 3364 3364
=============================================
+ Hits 19064 19066 +2
+ Misses 3762 3761 -1
|
ishantiw
approved these changes
Nov 23, 2023
shuse2
reviewed
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we test this on mainnet data? I think we might need to chunk the data for whole db iteration
With the mainnet data here it takes ~2mins16sec on macOs M1 to complete and produce the output hash. |
shuse2
approved these changes
Nov 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #9148
How was it solved?
Fixed incorrect read of database stream
How was it tested?
Under examples app pos-mainchain
./bin/run blockchain hash -d ~/.lisk/pos-mainchain