Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix config on application bootstrap #9152

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Conversation

ishantiw
Copy link
Contributor

What was the problem?

This PR resolves #9151

How was it solved?

  • Update config.json to have allowedMethods in rpc
  • Update dataPath to have a format ~/.lisk/<app_name>

How was it tested?

In order to test locally,

  1. build commander
  2. yarn link
  3. npm i -g
  4. ./bin/run init ~/Desktop/testapp
  5. cd ~/Desktop/testapp
  6. yarn link lisk-commander
  7. ./bin/run config:create --chain-id 02000001 --label 'testapp'
  8. check the config.json file for dataPath and rpc values

@ishantiw ishantiw requested a review from shuse2 November 23, 2023 16:43
@ishantiw ishantiw self-assigned this Nov 23, 2023
@ishantiw ishantiw changed the base branch from development to hotfix/6.0.1 November 23, 2023 16:43
@ishantiw ishantiw requested a review from mitsuaki-u November 23, 2023 16:48
Copy link
Contributor

@mitsuaki-u mitsuaki-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from comment

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #9152 (40e6c38) into hotfix/6.0.1 (1e73f05) will increase coverage by 0.83%.
The diff coverage is 0.00%.

❗ Current head 40e6c38 differs from pull request most recent head aa5803c. Consider uploading reports for the commit aa5803c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           hotfix/6.0.1    #9152      +/-   ##
================================================
+ Coverage         83.52%   84.35%   +0.83%     
================================================
  Files               606      655      +49     
  Lines             22826    24111    +1285     
  Branches           3364     3489     +125     
================================================
+ Hits              19065    20340    +1275     
- Misses             3761     3771      +10     
Files Coverage Δ
commander/src/utils/config.ts 100.00% <ø> (ø)
...mander/src/bootstrapping/commands/config/create.ts 34.37% <0.00%> (-1.99%) ⬇️

... and 99 files with indirect coverage changes

@ishantiw ishantiw requested a review from shuse2 November 23, 2023 17:31
@ishantiw ishantiw enabled auto-merge (squash) November 23, 2023 17:34
@ishantiw ishantiw merged commit f825978 into hotfix/6.0.1 Nov 23, 2023
8 checks passed
@ishantiw ishantiw deleted the 9151-fix-bootstrap-config branch November 23, 2023 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add allowedMethods in the config on bootstrap and fix dataPath
3 participants