Fix transaction history report (#2021)

* 🔨 Refactor code * 🐛 Fix history export logic * 🔨 Cache and reuse publicKeys * 🐛 Display all opening token balances * 🔨 Add failsafe to avoid infinite auto-rescheduling * 🐛 Flatten metadata entries list * 🐛 Fix normalizeTransactionFee method invocation * 🐛 Remove cyclic dependency * 📝 Add logs * 🐛 Ensure no duplicate entries * 🐛 No transaction fee entries for shared reward entries * 🔨 Add handling for legacy:reclaimLSK transaction * 🔨 Refactor code * ✅ Add unit tests * 🐛 Add fallback to fetch necessary missing events * ⬆️ Bump framework to v1.6.12 * ⚡ Update lisk-service-framework dependency * 🐛 Serialize BigInt to base 10 * ⚡ Add handling for pos:reportMisbehavior transactions * 🐛 Fix broken test * ✅ Add/fix unit tests * 🔨 Update test * ✅ Add tests * 🔨 Refactor code * 🐛 Set proper param format * 🔧 Increase broker timeout to 10sec * 👌 Apply review recommendations --------- Co-authored-by: nagdahimanshu <himanshu.nagda@lightcurve.io>
LiskArchive · Feb 8, 2024 · d566d68 · d566d68
1 parent 65e1f43
commit d566d68
Show file tree

Hide file tree

Showing 61 changed files with 4,953 additions and 3,022 deletions.
diff --git a/framework/dist/lisk-service-framework-1.6.12.tgz b/framework/dist/lisk-service-framework-1.6.12.tgz
diff --git a/framework/package.json b/framework/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "lisk-service-framework",
-	"version": "1.6.11",
+	"version": "1.6.12",
 	"description": "Lisk Service Framework",
 	"keywords": [
 		"lisk",

diff --git a/framework/src/queue.js b/framework/src/queue.js
@@ -68,7 +68,11 @@ const queueInstance = (
 		});
 
 		queue.on('failed', (job, err) => {
-			logger.warn(`${job.name} job failed with error: ${err.message}`);
+			const validationMessageString =
+				err.message === 'Parameters validation error!'
+					? String('\n\t- ').concat(err.data.map(e => e.message).join('\n\t- '))
+					: '';
+			logger.warn(`${job.name} job failed with error: ${err.message}${validationMessageString}`);
 			logger.debug(`${job.name} job failed with error:\n${err.stack}`);
 		});
 

diff --git a/framework/yarn.lock b/framework/yarn.lock
diff --git a/services/blockchain-app-registry/config.js b/services/blockchain-app-registry/config.js
@@ -19,7 +19,7 @@ const config = {};
 
 // Moleculer broker config
 config.transporter = process.env.SERVICE_BROKER || 'redis://lisk:password@127.0.0.1:6379/0';
-config.brokerTimeout = Number(process.env.SERVICE_BROKER_TIMEOUT) || 5; // in seconds
+config.brokerTimeout = Number(process.env.SERVICE_BROKER_TIMEOUT) || 10; // in seconds
 
 /**
  * External endpoints

diff --git a/services/blockchain-app-registry/package.json b/services/blockchain-app-registry/package.json
@@ -32,7 +32,7 @@
 	"dependencies": {
 		"bluebird": "^3.7.2",
 		"ioredis": "^5.3.2",
-		"lisk-service-framework": "https://github.com/LiskHQ/lisk-service/raw/5cb6fc8e9b9798595d1a4652b9148afcbfaaed1f/framework/dist/lisk-service-framework-1.6.11.tgz",
+		"lisk-service-framework": "https://github.com/LiskHQ/lisk-service/raw/8859790842fc7a1a937d25b59d1b6286c5e1176d/framework/dist/lisk-service-framework-1.6.12.tgz",
 		"lodash": "^4.17.21",
 		"node-fetch": "^2.6.1",
 		"octokit": "^3.1.2",

diff --git a/services/blockchain-app-registry/yarn.lock b/services/blockchain-app-registry/yarn.lock
diff --git a/services/blockchain-connector/methods/token.js b/services/blockchain-connector/methods/token.js
@@ -22,7 +22,7 @@ const {
 	getTokenBalances,
 	getTokenInitializationFees,
 	tokenHasEscrowAccount,
-	getTokenBalanceAtGenesis,
+	getTokenBalancesAtGenesis,
 } = require('../shared/sdk');
 
 module.exports = [
@@ -86,8 +86,8 @@ module.exports = [
 		params: {},
 	},
 	{
-		name: 'getTokenBalanceAtGenesis',
-		controller: async ({ address }) => getTokenBalanceAtGenesis(address),
+		name: 'getTokenBalancesAtGenesis',
+		controller: async ({ address }) => getTokenBalancesAtGenesis(address),
 		params: {
 			address: { optional: false, type: 'string' },
 		},

diff --git a/services/blockchain-connector/package.json b/services/blockchain-connector/package.json
@@ -40,7 +40,7 @@
 		"bluebird": "^3.7.2",
 		"ioredis": "^5.3.2",
 		"knex": "^2.4.0",
-		"lisk-service-framework": "https://github.com/LiskHQ/lisk-service/raw/5cb6fc8e9b9798595d1a4652b9148afcbfaaed1f/framework/dist/lisk-service-framework-1.6.11.tgz",
+		"lisk-service-framework": "https://github.com/LiskHQ/lisk-service/raw/8859790842fc7a1a937d25b59d1b6286c5e1176d/framework/dist/lisk-service-framework-1.6.12.tgz",
 		"moment": "^2.29.4",
 		"signals": "^1.0.0",
 		"tar": "^6.1.11"

diff --git a/services/blockchain-connector/shared/sdk/index.js b/services/blockchain-connector/shared/sdk/index.js
@@ -65,7 +65,7 @@ const {
 	getTotalSupply,
 	getTokenInitializationFees,
 	updateTokenInfo,
-	getTokenBalanceAtGenesis,
+	getTokenBalancesAtGenesis,
 } = require('./token');
 
 const {
@@ -188,7 +188,7 @@ module.exports = {
 	getSupportedTokens,
 	getTotalSupply,
 	getTokenInitializationFees,
-	getTokenBalanceAtGenesis,
+	getTokenBalancesAtGenesis,
 
 	// PoS
 	getAllPosValidators,

diff --git a/services/blockchain-connector/shared/sdk/token.js b/services/blockchain-connector/shared/sdk/token.js
@@ -75,7 +75,7 @@ const updateTokenInfo = async () => {
 	totalSupply = await getTotalSupply(true);
 };
 
-const getTokenBalanceAtGenesis = async address => {
+const getTokenBalancesAtGenesis = async address => {
 	const MODULE_TOKEN_SUBSTORE_USER = 'userSubstore';
 
 	const tokenModuleGenesisAssets = await getGenesisAssetByModule({
@@ -84,7 +84,7 @@ const getTokenBalanceAtGenesis = async address => {
 	});
 
 	const balancesAtGenesis = tokenModuleGenesisAssets[MODULE_TOKEN_SUBSTORE_USER];
-	const balancesByAddress = balancesAtGenesis.find(e => e.address === address);
+	const balancesByAddress = balancesAtGenesis.filter(e => e.address === address);
 
 	return balancesByAddress;
 };
@@ -99,5 +99,5 @@ module.exports = {
 	getTotalSupply,
 	getTokenInitializationFees,
 	updateTokenInfo,
-	getTokenBalanceAtGenesis,
+	getTokenBalancesAtGenesis,
 };