Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Can't send transactions leaving the account with less than 0.05 LSK #2023

Conversation

sameersubudhi
Copy link
Contributor

What was the problem?

This PR resolves #2022

How was it solved?

  • Fix balance validation logic

How was it tested?

Locally/ already patched on prod

@sameersubudhi sameersubudhi force-pushed the 2022-cannot-send-outgoing-transactions-with-balance-less-than-0_05-lsk branch from 93386b7 to bc60739 Compare February 19, 2024 09:39
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68a16b0) 67.89% compared to head (bc60739) 67.89%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2023      +/-   ##
===============================================
- Coverage        67.89%   67.89%   -0.01%     
===============================================
  Files              303      303              
  Lines             5704     5703       -1     
  Branches          1081     1081              
===============================================
- Hits              3873     3872       -1     
  Misses            1831     1831              
Files Coverage Δ
...d/dataService/business/transactionsEstimateFees.js 93.40% <100.00%> (-0.04%) ⬇️

Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi merged commit e5e8011 into development Feb 19, 2024
10 checks passed
@sameersubudhi sameersubudhi deleted the 2022-cannot-send-outgoing-transactions-with-balance-less-than-0_05-lsk branch February 19, 2024 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't send transactions leaving the account with less than 0.05 LSK
2 participants