Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update NodeJS version to 18.19.1 #2026

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

sameersubudhi
Copy link
Contributor

What was the problem?

This PR resolves #2025

How was it solved?

  • Bump minimum supported NodeJS version to 18.19.1
  • Update Makefile, Dockerfile to read NodeJS version from .nvmrc instead of hardcoding
  • Update documentation

How was it tested?

Locally, ran against Lisk Core on mainnet and testnet

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5e8011) 67.89% compared to head (98757dc) 67.89%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2026   +/-   ##
============================================
  Coverage        67.89%   67.89%           
============================================
  Files              303      303           
  Lines             5703     5703           
  Branches          1081     1081           
============================================
  Hits              3872     3872           
  Misses            1831     1831           

Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected 👍

@sameersubudhi sameersubudhi merged commit ca00c80 into development Feb 20, 2024
10 checks passed
@sameersubudhi sameersubudhi deleted the 2025-update-nodejs-version-to-18_19_1 branch February 20, 2024 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update NodeJS version to 18.19.1
3 participants