Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update NodeJS version to 18.20.1 #2043

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

sameersubudhi
Copy link
Contributor

@sameersubudhi sameersubudhi commented Apr 4, 2024

What was the problem?

This PR resolves #2042

How was it solved?

  • Bump minimum supported NodeJS version to 18.20.1
  • Update documentation

How was it tested?

Locally, ran against Lisk Core on mainnet and testnet

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.89%. Comparing base (f665ca4) to head (ec02315).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2043   +/-   ##
============================================
  Coverage        67.89%   67.89%           
============================================
  Files              303      303           
  Lines             5703     5703           
  Branches          1081     1081           
============================================
  Hits              3872     3872           
  Misses            1831     1831           
Files Coverage Δ
services/blockchain-connector/config.js 100.00% <100.00%> (ø)
services/gateway/tests/constants/utils.js 100.00% <ø> (ø)

@sameersubudhi sameersubudhi force-pushed the 2042-update-nodejs-version-to-18_20_1 branch from 0f60065 to b5905b1 Compare April 4, 2024 13:52
Copy link
Contributor

@Nazgolze Nazgolze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi removed the request for review from Tschakki April 8, 2024 11:41
@sameersubudhi sameersubudhi merged commit 0e21e4c into development Apr 8, 2024
11 checks passed
@sameersubudhi sameersubudhi deleted the 2042-update-nodejs-version-to-18_20_1 branch April 8, 2024 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update NodeJS version to 18.20.1
3 participants