Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Improve indexing process #2047

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

sameersubudhi
Copy link
Contributor

@sameersubudhi sameersubudhi commented Apr 8, 2024

What was the problem?

This PR resolves #2046

How was it solved?

  • Replace token_getBalances invocation with token_getBalance when updating account balances during the indexing process
  • Include mainnet/testnet genesis blocks by default within connector microservice

How was it tested?

Locally, against the mainnet

@sameersubudhi sameersubudhi self-assigned this Apr 8, 2024
@sameersubudhi sameersubudhi marked this pull request as draft April 8, 2024 22:30
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.89%. Comparing base (0e21e4c) to head (76210b5).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2047   +/-   ##
============================================
  Coverage        67.89%   67.89%           
============================================
  Files              303      303           
  Lines             5703     5703           
  Branches          1081     1081           
============================================
  Hits              3872     3872           
  Misses            1831     1831           

@sameersubudhi sameersubudhi force-pushed the 2046-improve-indexing-process branch from 81537b2 to 6554bb2 Compare April 8, 2024 22:45
@sameersubudhi sameersubudhi marked this pull request as ready for review April 9, 2024 08:13
@sameersubudhi sameersubudhi force-pushed the 2046-improve-indexing-process branch from 1943bd8 to 76210b5 Compare April 9, 2024 13:05
Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected 🚀

@sameersubudhi sameersubudhi merged commit 0c575fe into development Apr 9, 2024
10 checks passed
@sameersubudhi sameersubudhi deleted the 2046-improve-indexing-process branch April 9, 2024 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve indexing process
2 participants