Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LISKDOCS-19] Introduction to Web3 app development #260

Open
wants to merge 46 commits into
base: development
Choose a base branch
from

Conversation

Tschakki
Copy link
Member

@Tschakki Tschakki commented Dec 5, 2024

No description provided.

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger
@Tschakki Tschakki self-assigned this Dec 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger
…k-documentation into liskdocs-19-mobile-dapp-guide
@Tschakki Tschakki requested a review from TalhaMaliktz January 6, 2025 10:56
@Tschakki Tschakki marked this pull request as ready for review January 6, 2025 10:56
Copy link
Collaborator

@TalhaMaliktz TalhaMaliktz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the following!

docs/building-on-lisk/web3-app-development.mdx Outdated Show resolved Hide resolved
docs/building-on-lisk/web3-app-development.mdx Outdated Show resolved Hide resolved
docs/building-on-lisk/web3-app-development.mdx Outdated Show resolved Hide resolved
docs/building-on-lisk/web3-app-development.mdx Outdated Show resolved Hide resolved
docs/building-on-lisk/web3-app-development.mdx Outdated Show resolved Hide resolved
docs/building-on-lisk/web3-app-development.mdx Outdated Show resolved Hide resolved
docs/building-on-lisk/web3-app-development.mdx Outdated Show resolved Hide resolved
docs/building-on-lisk/web3-app-development.mdx Outdated Show resolved Hide resolved
docs/building-on-lisk/web3-app-development.mdx Outdated Show resolved Hide resolved
Tschakki and others added 2 commits January 10, 2025 09:57

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-authored-by: Muhammad Talha <13951043+TalhaMaliktz@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Tschakki Tschakki requested a review from TalhaMaliktz January 10, 2025 08:58
Copy link
Collaborator

@TalhaMaliktz TalhaMaliktz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Copy link
Contributor

@matjazv matjazv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current documentation looks good to me!

Maybe consider extending it with below topics if you find them useful for this page:

  • Security considerations in Web3 applications (smart contract audits, secure key management, handling user data, bug bounties)
  • Testing and deployment (local development env, testnets, continuous integration, monitoring)
  • Onboarding Web2 users (abstracting wallet setup, gas fee management, support and community)

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger
@Tschakki
Copy link
Member Author

Broken anchor found! image

this seems to be in the translation /ind/, which doesn't exist yet for this content... How did you get the error?

I got it when I ran npm run build && npm run serve; if it is missing a file, I think we can make it part of our workflow to add a file in the /ind folder as well whenever we have the final and approved English version of the new file.

I added the file, which did not resolve the error. Then I changed format of the heading, and it fixed it, so I changed it in the original file as well.. not sure why the error was showing up for the translation and not original file though 🤔

Copy link
Collaborator

@TalhaMaliktz TalhaMaliktz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Verified

This commit was signed with the committer’s verified signature.
Tschakki Mona Bärenfänger

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-authored-by: Matjaz Verbole <verbole@gmail.com>
Copy link
Contributor

@matjazv matjazv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants