Update frontend #17
Merged
Update frontend #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagdahimanshu
force-pushed
the
14-update-frontend
branch
from
684c315 to
5318cfd
Compare
nagdahimanshu
force-pushed
the
14-update-frontend
branch
from
5318cfd to
af4afc4
Compare
sameersubudhi
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Looks good and works as expected!
- Can we please make the transaction hash clickable so that it opens a new browser window with the block explorer? Perhaps we can take the explorer URL as an flag (
explorer.url)/env variable where the default is set to https://sepolia-blockscout.lisk.com. - Let's also add a
explorer.tx.pathflag, defaulting totx - In addition, let's rename the
token-addressflag totoken.addressfor consistency with the remaining flags.
nagdahimanshu
force-pushed
the
14-update-frontend
branch
from
46fc2a4 to
ab547bc
Compare
ikem-legend
approved these changes
Jul 5, 2024
nagdahimanshu
force-pushed
the
14-update-frontend
branch
from
c9cc3de to
227f866
Compare
nagdahimanshu
force-pushed
the
14-update-frontend
branch
from
227f866 to
846ef54
Compare
sameersubudhi
approved these changes
Jul 5, 2024
shuse2
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #14
How was it solved?
How was it tested?
Local