fix: Compilation problems detected on macos, linux #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- headCmpEx() changed to not use the atomic copy operator that is set to deleted in macos (Xcode 14). Fixing the following error:
```sh
./simdb.hpp:554:41: error: copying parameter of type 'std::atomic<u64>' (aka 'atomic<unsigned long long>') invokes deleted constructor
}while( !headCmpEx( &curHead.asInt, nxtHead.asInt) );
```
- changing `decltype(f(vi))` to `decltype(f(VerIdx()))` in runMatch to fix the following error
```sh
./simdb.hpp:1349:99: error: use of undeclared identifier 'vi'
bool runMatch(const void *const key, u32 klen, u32 hash, FUNC f, T defaultRet = decltype(f(vi))() ) const
```
|
It would also be good if you could get this to also work with Visual C++ 20. I'll get errors unless I define: /D _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #4 and #8
decltype(f(vi))todecltype(f(VerIdx()))in runMatch to fix the following errorThe example is tested and works perfectly. My platform (Macos m1, Xcode14)