services/yabai: cleanup and add errorLogFile/outLogFile

[khaneliman]

Similar to #840 for allowing one to monitor the application's output in their logs.

[Samasaur1]

I noticed some inconsistencies about the log files. Intuitively (and based on #1226 which includes the upstream plist) I'd say we probably want separate standard output and standard error logs by default

[Samasaur1]

Otherwise this PR looks great to me

[Samasaur1]

Not gonna comment on the other two PRs but I have the same question about log location

[0rphee]

Just chiming in, the default yabai plist (as I'm writing this) can be found here: https://github.com/koekeishiya/yabai/blob/f4ada8d557aeb9c8ba0d031ee6f645acffff50fd/src/misc/service.h#L8-L42

As a user, I think its better to keep most of it as-is, to avoid differences in behavior from a 'normal' yabai installation. However, it would be nice to allow the option to override the launch agent configuration.

[Samasaur1]

Yeah, just the fct that the option exists means that users will be able to override it. I think we should match upstream and change the default log location to under /tmp

[spikespaz]

This PR seems to have changed the formatter, which makes for a noisy diff.

Could you please format the original file with your formatter, and standardize it for nix-darwin, and then rebase this PR to produce a clean diff, with only changes necessary for the stated goal?

Either that, or try to make this change without a formatter.

[khaneliman]

This PR seems to have changed the formatter, which makes for a noisy diff.

Could you please format the original file with your formatter, and standardize it for nix-darwin, and then rebase this PR to produce a clean diff, with only changes necessary for the stated goal?

Either that, or try to make this change without a formatter.

It's already 2 commits to separate the formatting from the function.