Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{environment,nix-tools}: correct default $PATH ordering to match macOS #1277

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

emilazy
Copy link
Collaborator

@emilazy emilazy commented Jan 17, 2025

No description provided.

Copy link
Contributor

@Samasaur1 Samasaur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that this is the PATH ordering that macOS uses on macOS 12, 14, and 15 (contents of /etc/paths).

I do see that at least on macOS 14 and above, there's also a /System/Cryptexes/App/usr/bin directory in PATH. Do we want to include this directory in the default PATH as well?

/usr/local/bin
/System/Cryptexes/App/usr/bin
/usr/bin
/bin
/usr/sbin
/sbin

(contents of /etc/paths on macOS 14.7)

@emilazy
Copy link
Collaborator Author

emilazy commented Jan 17, 2025

Yeah, plausibly. I think if they put out a rapid security response update that fixed a vulnerability in /usr/bin or something the replacement would go there? I’m not sure. There’s also more stuff in /etc/paths.d/10-cryptex and /etc/paths.d/100-rvictl that gets added by default. Adding those seems like a reasonable idea, just not one I’m as certain about as this change. (But I’d probably approve a PR to do so.)

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did you run into an issue with the ordering?

@emilazy
Copy link
Collaborator Author

emilazy commented Jan 18, 2025

Nah, I was just checking it against a stock installation while doing other work on these files and noticed the discrepancy.

@emilazy emilazy merged commit 3924b55 into LnL7:master Jan 18, 2025
3 checks passed
@emilazy emilazy deleted the push-yxsrvorpzlor branch January 18, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants