Merge remote-tracking branch 'origin/dev' into issue/OSOE-935

Lombiq · Jan 10, 2025 · 2db3a83 · 2db3a83
2 parents 0b554d7 + 09bca12
commit 2db3a83
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 4 deletions.
diff --git a/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs b/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs
@@ -45,7 +45,10 @@ public Task VerifyBlogImage() =>
                 var blogImageElementSelector = By.ClassName("field-name-blog-image");
 
                 // Here we check that the rendered content visually equals the baseline image within a given error
-                // percentage. You can read more about this in the AssertVisualVerificationApproved method documentation.
+                // percentage. You can read more about this in the AssertVisualVerificationApproved method
+                // documentation. Keep in mind, that after a browser update, font rendering and spacing can change. To
+                // prevent visual verification tests from failing, you should apply a percentage of approximately 5 in
+                // cases of images with a lot of text.
                 context.AssertVisualVerificationApproved(blogImageElementSelector, 0);
             });
 
@@ -68,8 +71,10 @@ public Task VerifyNavbar(Browser browser) =>
                 var navbarElementSelector = By.ClassName("navbar-brand");
 
                 // Here we check that the rendered content visually equals the baseline image within a given error
-                // percentage using different baseline image on each platform and browser. You can read more about
-                // this in the AssertVisualVerificationApproved method documentation.
+                // percentage using different baseline image on each platform and browser. You can read more about this
+                // in the AssertVisualVerificationApproved method documentation. Keep in mind, that after a browser
+                // update, font rendering and spacing can change. To prevent visual verification tests from failing,
+                // you should apply a percentage of approximately 5 in cases of images with a lot of text.
                 context.AssertVisualVerificationApproved(
                     navbarElementSelector,
                     0,

diff --git a/...ficationTests_VerifyNavbar_By_ClassName[Contains]_-navbar-brand_Unix_chrome.png b/...ficationTests_VerifyNavbar_By_ClassName[Contains]_-navbar-brand_Unix_chrome.png
diff --git a/...ationTests_VerifyNavbar_By_ClassName[Contains]_-navbar-brand_Win32NT_chrome.png b/...ationTests_VerifyNavbar_By_ClassName[Contains]_-navbar-brand_Win32NT_chrome.png
diff --git a/Lombiq.Tests.UI.Tests.UI/Recipes/Lombiq.Tests.UI.Tests.UI.WorkflowShortcutsTests.recipe.json b/Lombiq.Tests.UI.Tests.UI/Recipes/Lombiq.Tests.UI.Tests.UI.WorkflowShortcutsTests.recipe.json
@@ -3,7 +3,7 @@
   "displayName": "Lombiq UI Testing Toolbox - UI Tests - WorkflowShortcutsTests",
   "description": "Test recipe for WorkflowShortcutsTests.",
   "author": "Lombiq Technologies",
-  "website": "https://github.com/Lombiq/Orchard-Privacy",
+  "website": "https://github.com/Lombiq/UI-Testing-Toolbox",
   "version": "1.0",
   "issetuprecipe": false,
   "categories": [

diff --git a/Lombiq.Tests.UI/Services/WebDriverFactory.cs b/Lombiq.Tests.UI/Services/WebDriverFactory.cs
@@ -148,6 +148,11 @@ private static TDriverOptions SetCommonChromiumOptions<TDriverOptions>(
         options.AddArgument("disable-accelerated-2d-canvas");
         options.AddArgument("disable-gpu"); // #spell-check-ignore-line
 
+        // Setting font rendering to keep the text as they are for visual verification testing.
+        options.AddArgument("font-render-hinting=none");
+        options.AddArgument("disable-font-subpixel-positioning");
+        options.AddArgument("disable-lcd-text");
+
         // Setting color profile explicitly to sRGB to keep colors as they are for visual verification testing.
         options.AddArgument("force-color-profile=sRGB");