Fixed hash equality check not working on Velocity #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump? |
|
@itsTyrion can you send a version working with velocity? |
|
Can do but I gotta rebase it on top of the fixes done since mine and I'm not on PC right now, ping me if I forget |
|
@itsTyrion can you send it to me too? |
|
Thanks! |
|
@LoneDev6 ? please merge this 💯 |
|
" I will accept pull requests as soon as they work correctly." this one has been working correctly since.. always |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is,
equal_pack_attributes.hashdoes not function correctly on Velocity, because Objects.equals is used on a byte array, which only checks for reference equality, which cannot work because the getter always creates a clone.After a quick test, the resource pack seems to be correctly skipped.