Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync alive #172

Closed
wants to merge 18 commits into from
Closed

Fix sync alive #172

wants to merge 18 commits into from

Conversation

dnzxy
Copy link
Contributor

@dnzxy dnzxy commented Jul 19, 2024

This PR brings changes from #164 to dev. Please see #164 for detailed change log and testing results.

ps2 and others added 18 commits March 17, 2023 10:36
Merge dev into main for 3.2.1 release.
Both methods are using "github", so I think we probably want to be a little clearer on this.
This exposes the name of the branch or tag that the Build Loop step is running. This helps show users what is being built (and thus a history) in the GitHub Actions view.
Add tag/branch name to build step
Adding a step to workflow jobs that interface Apple servers, as a workaround for build issues caused by runner clocks being out of sync. See https://github.com/actions/runner issue number 2996 for details.

name: Sync clock
run: sudo sntp -sS time.windows.com
Added to the following workflows / jobs:

validate_secrets.yml / validate-fastlane-secrets
add_identifiers.yml / identifiers
build_loop.yml / build
create_certs.yml / certificates
…it#124)

* update for Xcode 15, even in comments, and node 20 in actions

* bump up to macos-14 and Xcode 15.3, now available
- Added logic to extend the alive check for the existence of either `alive-main` or `alive-dev` branches.
  - Resolved an issue where unexpected successes were occurring when failures were expected.
  - Implemented a check to determine the existence of the `alive-main` and `alive-dev` branches and create them if they do not exist.

- Introduced a mechanism to identify the current branch being run (either `main` or `dev`).
  - Based on the current branch, the corresponding alive branch (`alive-main` or `alive-dev`) will be used to check for upstream changes.

- Set a new variable `ABORT_SYNC` to `true` when the current branch is neither `dev` nor `main`.
  - The syncing attempt will proceed based on the `ABORT_SYNC` variable status.

- Ensured proper branch synchronization to prevent build inconsistencies and failures

- Addresses issue LoopKit/Loop#2192

- Updates app store connect link for validation error hints to new Apple URL scheme
Co-Authored-By: ebouchut <ebouchut@users.noreply.github.com>
@dnzxy
Copy link
Contributor Author

dnzxy commented Jul 20, 2024

I‘ll close this in favor of #175 with a cleaner commit history (fresh branch instead of pulled-in changes).
Thank you @marionbarker 🙏

@dnzxy dnzxy closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants