Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_certs workflow and Fastlane lane for Distribution certificate management #228

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions .github/workflows/check_certs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
name: Check Certificates
run-name: Check Certificates (${{ github.ref_name }})

on:
workflow_dispatch:

env:
EXPIRATION_WARNING_DAYS: 7

jobs:
check_certs:
runs-on: ubuntu-latest
env:
FASTLANE_ISSUER_ID: ${{ secrets.FASTLANE_ISSUER_ID }}
FASTLANE_KEY_ID: ${{ secrets.FASTLANE_KEY_ID }}
FASTLANE_KEY: ${{ secrets.FASTLANE_KEY }}
outputs:
new_certificate_needed: ${{ steps.set_output.outputs.new_certificate_needed }}

steps:
- name: Checkout repository
uses: actions/checkout@v3
bjornoleh marked this conversation as resolved.
Show resolved Hide resolved

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.1'

- name: Install dependencies
run: bundle install

- name: Check Certificates and create or renew if needed
env:
FASTLANE_USER: ${{ secrets.APPLE_ID }}
FASTLANE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
run: bundle exec fastlane check_and_renew_certificates
id: check_certs

- name: Set output based on Fastlane result
id: set_output
run: |
CERT_STATUS_FILE="${{ github.workspace }}/fastlane/new_certificate_needed.txt"
ENABLE_NUKE_CERTS=${{ vars.ENABLE_NUKE_CERTS }}

if [ -f "$CERT_STATUS_FILE" ]; then
CERT_STATUS=$(cat "$CERT_STATUS_FILE" | tr -d '\n' | tr -d '\r') # Read file content and strip newlines
echo "new_certificate_needed: $CERT_STATUS"
echo "new_certificate_needed=$CERT_STATUS" >> $GITHUB_OUTPUT
else
echo "Certificate status file not found. Defaulting to false."
echo "new_certificate_needed=false" >> $GITHUB_OUTPUT
fi

# Check if ENABLE_NUKE_CERTS is not set to true
if [ "$CERT_STATUS" = "true" ] && [ "$ENABLE_NUKE_CERTS" != "true" ]; then
echo "::notice::🔔 Nuke certificates was skipped because the repository variable ENABLE_NUKE_CERTS is not set to 'true'."
fi

# Nuke Certs if needed, and if the repository variable ENABLE_NUKE_CERTS is set to 'true' (without quotes)
nuke_certs:
needs: check_certs
runs-on: macos-14
if: ${{ needs.check_certs.outputs.new_certificate_needed == 'true' && vars.ENABLE_NUKE_CERTS == 'true' }}
steps:
- name: Debug check_certs output
run: echo "new_certificate_needed=${{ needs.check_certs.outputs.new_certificate_needed }}"

- name: Checkout repository
uses: actions/checkout@v3
bjornoleh marked this conversation as resolved.
Show resolved Hide resolved

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.1'

- name: Install dependencies
run: bundle install

- name: Run Fastlane nuke_certs
run: bundle exec fastlane nuke_certs
env:
TEAMID: ${{ secrets.TEAMID }}
GH_PAT: ${{ secrets.GH_PAT }}
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
FASTLANE_USER: ${{ secrets.FASTLANE_USER }}
FASTLANE_KEY_ID: ${{ secrets.FASTLANE_KEY_ID }}
FASTLANE_ISSUER_ID: ${{ secrets.FASTLANE_ISSUER_ID }}
FASTLANE_KEY: ${{ secrets.FASTLANE_KEY }}
FASTLANE_SKIP_ALL_LANE_SUMMARIES: "true"

- name: Annotate Summary after Nuke
run: |
echo "::warning::⚠️⚠️⚠️ All Distribution certificates and TestFlight profiles have been revoked."


# Trigger create_certs.yml if nuke_certs ran
trigger_create_certs:
needs: [check_certs, nuke_certs]
uses: ./.github/workflows/create_certs.yml
secrets: inherit

# Annotate Summary after Certificate Creation
annotate_summary:
needs: trigger_create_certs
runs-on: ubuntu-latest
steps:
- name: Annotate Summary
run: |
echo "::warning::⚠️⚠️⚠️ Certificates have been recreated successfully."
echo "::warning::⚠️⚠️⚠️ If you have other apps being distributed by GitHub Actions / Fastlane / TestFlight,"
echo "::warning::⚠️⚠️⚠️ please run the '3. Create Certificates' workflow for each of these apps to allow these apps to be built."
echo "::warning::✅✅✅ But don't worry about your existing TestFlight builds, they will keep working!"
3 changes: 1 addition & 2 deletions .github/workflows/create_certs.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: 3. Create Certificates
run-name: Create Certificates (${{ github.ref_name }})
on:
workflow_dispatch:
on: [workflow_call, workflow_dispatch]

jobs:
validate:
Expand Down
73 changes: 72 additions & 1 deletion fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -277,4 +277,75 @@ platform :ios do
git_basic_authorization: Base64.strict_encode64("#{GITHUB_REPOSITORY_OWNER}:#{GH_PAT}")
)
end
end

desc "Check Certificates and Trigger Workflow for Expired or Missing Certificates"
lane :check_and_renew_certificates do
setup_ci if ENV['CI']
ENV["MATCH_READONLY"] = false.to_s

# Authenticate using App Store Connect API Key
api_key = app_store_connect_api_key(
key_id: ENV["FASTLANE_KEY_ID"],
issuer_id: ENV["FASTLANE_ISSUER_ID"],
key_content: ENV["FASTLANE_KEY"] # Ensure valid key content
)

# Initialize flag to track if renewall of certificates is needed
new_certificate_needed = false

# Fetch all certificates
certificates = Spaceship::ConnectAPI::Certificate.all

# Filter for Distribution Certificates
distribution_certs = certificates.select { |cert| cert.certificate_type == "DISTRIBUTION" }

# Handle case where no distribution certificates are found
if distribution_certs.empty?
puts "⚠️ No distribution certificates found! Triggering workflow to create new certificates."
new_certificate_needed = true
else
# Get expiration warning days from ENV or default to 7
expiration_warning_days = (ENV['EXPIRATION_WARNING_DAYS'] || 7).to_i

# Check for expiration
distribution_certs.each do |cert|
expiration_date = Time.parse(cert.expiration_date)

puts "Checking Distribution Certificate: #{cert.id}, Expiration: #{expiration_date}"

if expiration_date < Time.now
puts "❌ Certificate #{cert.id} is already expired!"
new_certificate_needed = true
elsif expiration_date < Time.now + expiration_warning_days * 24 * 60 * 60
puts "⚠️ Certificate #{cert.id} is expiring within #{expiration_warning_days} days! Nuking the certificate for renewal! ⚠️"
bjornoleh marked this conversation as resolved.
Show resolved Hide resolved
new_certificate_needed = true
else
puts "✅ Certificate #{cert.id} is valid, and will not expire during the next #{expiration_warning_days} days"
end
end
end

# Write result to new_certificate_needed.txt
file_path = File.expand_path('new_certificate_needed.txt')
File.write(file_path, new_certificate_needed ? 'true' : 'false')

# Handle output for triggering workflow
if new_certificate_needed
puts "❌ Certificate is expired or no certificates found. Creating flag file to trigger renewal or creation of certificate."
puts ""
puts "⚠️⚠️⚠️ All Distribution certificates and TestFlight profiles are being revoked."
puts "⚠️⚠️⚠️ If you have other apps being distributed by GitHub Actions / Fastlane / TestFlight,"
puts "⚠️⚠️⚠️ please run the '3. Create Certificates' workflow for each of these apps to allow these apps to be built."
puts ""
puts "✅✅✅ But don't worry about your existing TestFlight builds, they will keep working!"
else
puts "✅ No certificates are expired or missing. No action required."
end

# Log the absolute path and contents of the new_certificate_needed.txt file
puts ""
puts "Absolute path of new_certificate_needed.txt: #{file_path}"
new_certificate_needed_content = File.read(file_path)
puts "Certificate creation or renewal needed: #{new_certificate_needed_content}"
end
end