Debugger improvements #28

LukasKalbertodt · 2018-08-27T08:01:34Z

Log and ASM views are now scrollable
ASM view will cache decoded instructions to show instructions before PC
Views are updated only when necessary, which should reduce CPU usage
Better structure

CC #18
Closes #26
Closes #27

LukasKalbertodt · 2018-08-27T13:39:24Z

I couldn't keep myself from implementing more stuff. Most importantly:

Fix quite a few PPU bugs (I know, this has nothing to do with the debugger, sorry for non-atomic PRs :P)
Add box showing (almost) all PPU register (in a second right panel)
Reduce CPU usage when debugger is paused
You can now view, set and unset breakpoints by clicking in the ASM view

But I'm gonna stop now. So this PR is ready.

- Decoded instructions are cached - Instructions before PC are showed too - An arrow points to the instruction PC is pointing to

jovobe · 2018-08-28T00:46:58Z

core/src/machine/ppu.rs

-                (43..144, _) => {
-                    // TODO: H-Blank
-                    // debug!("[ppu] hblank. current_line: {}", self.current_line);
+                (43..144, col) if self.phase() == Phase::HBlank && col == 160 => {


Use SCREEN_WIDTH instead of magic number 160.

jovobe · 2018-08-28T00:47:48Z

core/src/machine/ppu.rs

@@ -290,6 +357,13 @@ impl Ppu {
        while self.fifo.len() > 8 && pixel_pushed < 4 {
            self.push_pixel(display);
            pixel_pushed += 1;
+
+            // We we are at the end of the line, stop everything and go to


The "we" cloned itself 😱

jovobe · 2018-08-28T00:47:54Z

core/src/machine/ppu.rs

+
+            // We we are at the end of the line, stop everything and go to
+            // H-Blank.
+            if self.current_column == 160 {


Use SCREEN_WIDTH instead of magic number 160.

… builds

This reduces the time required for `NativeWindow::update()` from around 1,5ms to 200µs when the debugger is paused

Now pausing and doing nothing in the debugger needs almost no CPU. More importantly: since the TUI is only updated every fifth frame, the CPU usage is also lower when the emulator is running.

Now we don't use `TextView` internally anymore and do everything ourselves. This has a significant speed advantage, but means that long lines aren't wrapping anymore. The log message can still use line breaks, though.

LukasKalbertodt · 2018-08-29T22:09:48Z

I, again, worked on this instead of doing other stuff 😩

I guess these generated comments could come handy.

Other changes include log level via CLI and performance improvements.

These comments can potentially show more information if we want to.

There might be ways to make the debugger compile on Windows, but I don't think it's worth the trouble.

jovobe · 2018-08-31T12:52:10Z

core/src/machine/ppu.rs

+                        info!("[ppu] LCD was enabled");
+                        self.set_phase(Phase::OamSearch);
+                        self.cycle_in_line = 0;
+                        // TODO: also reset other stuff?


Do we need to reset the current line here too? (e.g. self.current_line = Byte::new(0);)

I don't think so. The current line is set to 0 a few lines below, when the LCD is disabled. I actually think that most things should be "reset" when the LCD is disabled instead of when it is enabled.

I think the TODO is a bit outdated. But it might still be useful until we figured this out.

jovobe · 2018-08-31T13:25:00Z

I ignored everything in desktop/src/debug for the review.

LukasKalbertodt requested a review from jovobe August 27, 2018 08:01

LukasKalbertodt added 19 commits August 28, 2018 00:27

Restructure code in the TUI debugger

513f2f3

Wrap ASM view into scroll container

2205b78

Add Word::map

38df919

Make log view scrollable

25d8aa5

Don't update debugger views when it's not necessary

d515608

Improve ASM view

7c0d5ae

- Decoded instructions are cached - Instructions before PC are showed too - An arrow points to the instruction PC is pointing to

Fix ASM view boot ROM cache invalidation

5f52536

Scroll ASM view to the current instruction

ecc7619

Add getter methods for all registers of PPU

947b097

Add second right panel for TUI debugger

0f6da52

Make stack view scrollable

fa5d65c

Implement Display for ppu::Phase

34cef8e

Fix a ton of bugs in PPU and teach PPU about disabled/enabled LCD

313ade2

Initialize the screen with a friendly blue to make debugging PPU easier

f3ac32e

Add big PPU debugging info box

89916d0

Reduce TUI FPS in pause mode to save CPU

f593b30

Show breakpoints in ASM view

eb4d808

Fix forwarding of mouse events to children of the tab view

4dd1da9

Add and remove breakpoints via ASM view

4d26ccc

LukasKalbertodt force-pushed the debugger branch from 9cab544 to 4d26ccc Compare August 27, 2018 22:29

jovobe requested changes Aug 28, 2018

View reviewed changes

LukasKalbertodt added 7 commits August 28, 2018 15:53

Set current line to 0 when LCD gets disabled

467e4f3

Address comments on PR

42a5d09

Add CLI option to modify logger level and disable trace! in release…

59cbe0f

… builds

Limit the number of log messages shown in the debug view

67c117b

Don't update window buffer when it didn't change

80956f4

This reduces the time required for `NativeWindow::update()` from around 1,5ms to 200µs when the debugger is paused

Save CPU by updating the TUI views less often (every 5th frame)

e9787b7

Now pausing and doing nothing in the debugger needs almost no CPU. More importantly: since the TUI is only updated every fifth frame, the CPU usage is also lower when the emulator is running.

Accelerate rendering of the log view

d58a810

Now we don't use `TextView` internally anymore and do everything ourselves. This has a significant speed advantage, but means that long lines aren't wrapping anymore. The log message can still use line breaks, though.

Add filtering for the log view

7b63837

Add generated comments to the ASM view that show register names

6a61707

These comments can potentially show more information if we want to.

LukasKalbertodt force-pushed the debugger branch from 58a975d to 6a61707 Compare August 29, 2018 22:14

Make mahboi-desktop compile on Windows by disabling TUI debugger

a7c5e5f

There might be ways to make the debugger compile on Windows, but I don't think it's worth the trouble.

jovobe requested changes Aug 31, 2018

View reviewed changes

jovobe approved these changes Aug 31, 2018

View reviewed changes

jovobe merged commit c03a049 into master Aug 31, 2018

LukasKalbertodt deleted the debugger branch September 2, 2018 17:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Debugger improvements #28

Debugger improvements #28

LukasKalbertodt commented Aug 27, 2018 •

edited

Loading

LukasKalbertodt commented Aug 27, 2018

jovobe Aug 28, 2018

jovobe Aug 28, 2018

jovobe Aug 28, 2018

LukasKalbertodt commented Aug 29, 2018

jovobe Aug 31, 2018

LukasKalbertodt Aug 31, 2018

jovobe commented Aug 31, 2018

Debugger improvements #28

Debugger improvements #28

Conversation

LukasKalbertodt commented Aug 27, 2018 • edited Loading

LukasKalbertodt commented Aug 27, 2018

jovobe Aug 28, 2018

Choose a reason for hiding this comment

jovobe Aug 28, 2018

Choose a reason for hiding this comment

jovobe Aug 28, 2018

Choose a reason for hiding this comment

LukasKalbertodt commented Aug 29, 2018

jovobe Aug 31, 2018

Choose a reason for hiding this comment

LukasKalbertodt Aug 31, 2018

Choose a reason for hiding this comment

jovobe commented Aug 31, 2018

LukasKalbertodt commented Aug 27, 2018 •

edited

Loading