Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact information for Team page #402

Merged
merged 69 commits into from
Jan 27, 2025

Conversation

jennaswa
Copy link
Contributor

@jennaswa jennaswa commented Sep 2, 2024

Per the discussion in #397, the main purpose of this PR is to:

In addition, this would provide a good opportunity to update team members in preparation for our first upcoming R&R review, as decided in the Aug 20 business meeting. Namely:

Thanks!

@jennaswa jennaswa requested a review from a team September 2, 2024 10:01
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jennaswa !

I will opt out of including myself in community engagement, but will opt in for project organization.

Re: the build failure, I suspect the autogeneration from yaml might not like the links so much. @lilyminium would be best suited to weigh in on this.

_data/team/roles/project_organization.yml Outdated Show resolved Hide resolved
@lilyminium
Copy link
Member

lilyminium commented Sep 3, 2024

Re: github failure -- yup, I hadn't included Markdown support in the teams pages. I've opened #403 to include this so that should fix it. However, the caveat is that the initial YAML still has to be valid, so all the team member links should be encapsulated in quotes to tell YAML it's a string and not a list. (i.e. "[Jenna Swarthout Goddard](https://github.com/jennaswa)" instead of just plain [Jenna Swarthout Goddard](https://github.com/jennaswa))

_data/team/roles/code_of_conduct.yml Outdated Show resolved Hide resolved
_data/team/roles/community_engagement.yml Outdated Show resolved Hide resolved
_data/team/roles/continuous_integration.yml Outdated Show resolved Hide resolved
_data/team/roles/core_library_maintenance.yml Outdated Show resolved Hide resolved
_data/team/roles/core_library_maintenance.yml Outdated Show resolved Hide resolved
_data/team/roles/outreach.yml Outdated Show resolved Hide resolved
_data/team/roles/project_organization.yml Outdated Show resolved Hide resolved
_data/team/roles/releases_and_deployment.yaml Outdated Show resolved Hide resolved
_data/team/roles/relicensing_coordinator.yml Outdated Show resolved Hide resolved
_data/team/roles/social_media.yml Outdated Show resolved Hide resolved
@lilyminium
Copy link
Member

Added non-blocking comments for quotes. Otherwise LGTM -- thanks for this @jennaswa!

jennaswa and others added 3 commits September 3, 2024 16:38
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com>
Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com>
@orbeckst
Copy link
Member

@MDAnalysis/coredevs please review and sign off or ask for changes. Should be a quick thing. Thanks.

_data/team/roles/community_engagement.yml Show resolved Hide resolved
_data/team/roles/non_core_library_maintenance.yml Outdated Show resolved Hide resolved
@@ -7,5 +7,5 @@ tasks:
- Managing the switch to a new license
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retirement will be very well deserved!!!

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it should have been a "request changes".

Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
@orbeckst
Copy link
Member

@RMeli I incorporated your change request.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@orbeckst
Copy link
Member

@MDAnalysis/coredevs could you please have a look at the PR with your team assignments? We'd like to merge the current state by the end of the week — it's been sitting here for a very long time and with new coredevs coming in, we need to have a proper public representation of responsibilities.

If you are ok with the content, a quick ✅ LGTM approval would be very much appreciated, otherwise we'll assume silent assent. If anything needs changing please do that by Friday 2025-01-25 or as a later update to the page.

Thank you!

@orbeckst
Copy link
Member

@jennaswa given that you've been shepherding the PR through the ages, could you please be the one looking after getting it merged? Thank you!

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good from my side, thanks for doing this!

@jennaswa
Copy link
Contributor Author

I've been wondering if we should remove the role terms listed below the teams table (originally Nov 14 2023-Nov 14 2024). Another option is to say the roles listed are valid through the current quarter of the year, since this table should theoretically be updated after each of our quarterly team reviews in the future.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding myself on various roles I've had to take on by proxy of doing things like releases.

_data/team/roles/documentation.yml Show resolved Hide resolved
Copy link
Member

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding me @jennaswa! lgtm

jennaswa and others added 4 commits January 27, 2025 17:20
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
@jennaswa
Copy link
Contributor Author

Per Oliver's message from 01/22/25, I am going to merge this PR as there have been no further comments or requested changes. Should further discussion regarding the table take place (e.g., when evaluating our quarterly team reviews) and require changes, these changes will occur as a separate PR and update to the page. Thank you to all of those who helped push this update across the finish line!

@jennaswa jennaswa merged commit ad2468a into MDAnalysis:master Jan 27, 2025
1 check failed
@jennaswa jennaswa deleted the teams-page branch January 27, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants