-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contact information for Team page #402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jennaswa !
I will opt out of including myself in community engagement, but will opt in for project organization.
Re: the build failure, I suspect the autogeneration from yaml might not like the links so much. @lilyminium would be best suited to weigh in on this.
Re: github failure -- yup, I hadn't included Markdown support in the teams pages. I've opened #403 to include this so that should fix it. However, the caveat is that the initial YAML still has to be valid, so all the team member links should be encapsulated in quotes to tell YAML it's a string and not a list. (i.e. |
Added non-blocking comments for quotes. Otherwise LGTM -- thanks for this @jennaswa! |
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com>
Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com>
@MDAnalysis/coredevs please review and sign off or ask for changes. Should be a quick thing. Thanks. |
@@ -7,5 +7,5 @@ tasks: | |||
- Managing the switch to a new license |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retirement will be very well deserved!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it should have been a "request changes".
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
@RMeli I incorporated your change request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Co-authored-by: Oliver Beckstein <orbeckst@gmail.com>
…sword mgmt) to project org and mgmt team tasks
@MDAnalysis/coredevs could you please have a look at the PR with your team assignments? We'd like to merge the current state by the end of the week — it's been sitting here for a very long time and with new coredevs coming in, we need to have a proper public representation of responsibilities. If you are ok with the content, a quick ✅ LGTM approval would be very much appreciated, otherwise we'll assume silent assent. If anything needs changing please do that by Friday 2025-01-25 or as a later update to the page. Thank you! |
@jennaswa given that you've been shepherding the PR through the ages, could you please be the one looking after getting it merged? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still good from my side, thanks for doing this!
I've been wondering if we should remove the role terms listed below the teams table (originally Nov 14 2023-Nov 14 2024). Another option is to say the roles listed are valid through the current quarter of the year, since this table should theoretically be updated after each of our quarterly team reviews in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding myself on various roles I've had to take on by proxy of doing things like releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding me @jennaswa! lgtm
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Per Oliver's message from 01/22/25, I am going to merge this PR as there have been no further comments or requested changes. Should further discussion regarding the table take place (e.g., when evaluating our quarterly team reviews) and require changes, these changes will occur as a separate PR and update to the page. Thank you to all of those who helped push this update across the finish line! |
Per the discussion in #397, the main purpose of this PR is to:
In addition, this would provide a good opportunity to update team members in preparation for our first upcoming R&R review, as decided in the Aug 20 business meeting. Namely:
Thanks!