Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intel Fortran (ifort) errors because the boolean type doesn't match the prototype #2531

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion math/csint.f
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ Subroutine C9INI(ndata,xdata,fdata,dfdata,break,c)
Do j = 1,ndata
idx(j) = j
Enddo
Call SVRGP(ndata,xdata,break,1,idx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked this code better before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then should I change the prototype that doesn't match?

Call SVRGP(ndata,xdata,break,.true.,idx)
Do j = 1,ndata
c(1,idx(j)) = fdata(j)
c(2,idx(j)) = dfdata(j)
Expand Down
2 changes: 1 addition & 1 deletion math/dcsint.f
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ Subroutine DC9INI(ndata,xdata,fdata,dfdata,break,c)
Do j = 1,ndata
idx(j) = j
Enddo
Call DSVRGP(ndata,xdata,break,1,idx)
Call DSVRGP(ndata,xdata,break,.true.,idx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really supposed to be .true. - I hate fortran

Do j = 1,ndata
c(1,idx(j)) = fdata(j)
c(2,idx(j)) = dfdata(j)
Expand Down