Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add upgrades to PG devices #2571

Open
wants to merge 11 commits into
base: alpha
Choose a base branch
from

Conversation

santorofer
Copy link
Contributor

@santorofer santorofer commented May 9, 2023

Some clean up of the code.
Add debugging when using D-Tacq API that loads the STL.
Remove the usage of putData and instead directly add STL as text to the output nodes.

Note:
Passed tests.

@santorofer santorofer changed the title Fix: Add some upgrades Fix: Add some upgrades WRPG device May 11, 2023
@WhoBrokeTheBuild
Copy link
Member

Retest this please

WhoBrokeTheBuild and others added 4 commits May 24, 2023 15:54
Change the * to a + in the regex replace triggered by deltaTime being set. This was leading to a strange bug (possibly caused by going from python2 to python3) where it would match the entire fieldKey, and then match the empty space at the end of the line. 

So instead of:
`MEAN(fVal)`
it would become:
`MEAN(fVal)MEAN()`

.. which would then make InfluxDB reject our query.
@santorofer santorofer changed the title Fix: Add some upgrades WRPG device Fix: Add upgrades to PG devices May 24, 2023
@santorofer
Copy link
Contributor Author

Retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants