-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add upgrades to PG devices #2571
Open
santorofer
wants to merge
11
commits into
MDSplus:alpha
Choose a base branch
from
santorofer:fs-wrpg-updates
base: alpha
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+398
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhoBrokeTheBuild
force-pushed
the
fs-wrpg-updates
branch
from
May 19, 2023 17:20
648018b
to
036ec0d
Compare
Retest this please |
Change the * to a + in the regex replace triggered by deltaTime being set. This was leading to a strange bug (possibly caused by going from python2 to python3) where it would match the entire fieldKey, and then match the empty space at the end of the line. So instead of: `MEAN(fVal)` it would become: `MEAN(fVal)MEAN()` .. which would then make InfluxDB reject our query.
…device to noarch packages
…device to noarch packages
santorofer
changed the title
Fix: Add some upgrades WRPG device
Fix: Add upgrades to PG devices
May 24, 2023
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean up of the code.
Add debugging when using D-Tacq API that loads the STL.
Remove the usage of putData and instead directly add STL as text to the output nodes.
Note:
Passed tests.