-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update phrasing and revert task list changes
- Loading branch information
Showing
1 changed file
with
14 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,30 @@ | ||
| ### Purpose and background context | ||
| I'm PRing this repo first to refine the template and then I will PR [python-lambda-template](https://github.com/MITLibraries/python-lambda-template). Nitpick away, no suggestion is too minor as we refine this 🙂 | ||
| Describe the overall purpose of the PR changes and any useful background context. | ||
|
|
||
| ### How can a reviewer manually see the effects of these changes? | ||
| View this PR for an example of the updated template. | ||
| Explain how to see the proposed changes in the application if possible. | ||
|
|
||
| Delete this section if it isn't applicable to the PR. | ||
|
|
||
| ### Includes new or updated dependencies? | ||
| NO | ||
| YES | NO | ||
|
|
||
| #### Changes expectations for external applications? | ||
| NO | ||
| ### Changes expectations for external applications? | ||
| YES | NO | ||
|
|
||
| ### What are the relevant tickets? | ||
| - NA | ||
| - Include links to Jira Software and/or Jira Service Management tickets here. | ||
|
|
||
| ### Developer | ||
| - [ ] All new ENV is documented in README | ||
| - [ ] All new ENV has been added to staging and production environments | ||
| - [ ] All related Jira tickets are linked in commit message(s) | ||
| - [ ] Stakeholder approval has been confirmed (or is not needed) | ||
|
|
||
| ### Code Reviewer | ||
| |Reviewer 1|Reviewer 2|Checklist| | ||
| |-------------|-----------|-----------| | ||
| |<li> [ ] </li>|<li> [ ] </li>|The commit message is clear and follows our guidelines (not just this PR message)| | ||
| |<li> [ ] </li>|<li> [ ] </li>|There are appropriate tests covering any new functionality| | ||
| |<li> [ ] </li>|<li> [ ] </li>|The documentation has been updated or is unnecessary| | ||
| |<li> [ ] </li>|<li> [ ] </li>|The changes have been verified| | ||
| |<li> [ ] </li>|<li> [ ] </li>|New dependencies are appropriate or there were no changes| | ||
| ### Code Reviewer(s) | ||
| - [ ] The commit message is clear and follows our guidelines (not just this PR message) | ||
| - [ ] There are appropriate tests covering any new functionality | ||
| - [ ] The documentation has been updated or is unnecessary | ||
| - [ ] Any manual tests have been performed and verified | ||
| - [ ] New dependencies are appropriate or there were no changes | ||
|
|