-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Update pull request template based on team discussion
- Loading branch information
Showing
1 changed file
with
15 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,32 @@ | ||
| ### What does this PR do? | ||
|
|
||
| Describe the overall purpose of the PR changes. Doesn't need to be as specific as the | ||
| individual commits. | ||
|
|
||
| ### Helpful background context | ||
|
|
||
| Describe any additional context beyond what the PR accomplishes if it is likely to be | ||
| ### Purpose and background context | ||
| Describe the overall purpose of the PR changes and any additional context that is likely to be | ||
| useful to a reviewer. | ||
|
|
||
| Delete this section if it isn't applicable to the PR. | ||
|
|
||
| ### How can a reviewer manually see the effects of these changes? | ||
|
|
||
| Explain how to see the proposed changes in the application if possible. | ||
|
|
||
| Delete this section if it isn't applicable to the PR. | ||
|
|
||
| ### Includes new or updated dependencies? | ||
| YES | NO | ||
|
|
||
| #### Changes expectations for external applications? | ||
| YES | NO | ||
|
|
||
| ### What are the relevant tickets? | ||
|
|
||
| Include links to Jira Software and/or Jira Service Management tickets here. | ||
| - Include links to Jira Software and/or Jira Service Management tickets here. | ||
|
|
||
| ### Developer | ||
|
|
||
| - [ ] All new ENV is documented in README (or there is none) | ||
| - [ ] Stakeholder approval has been confirmed (or is not needed) | ||
| - [ ] [ ] All new ENV is documented in README | ||
| - [ ] [ ] All new ENV has been added to staging and production environments | ||
| - [ ] [ ] All related Jira tickets are linked in commit message(s) | ||
| - [ ] [ ] Stakeholder approval has been confirmed (or is not needed) | ||
|
|
||
| ### Code Reviewer | ||
| - [ ] [ ] The commit message is clear and follows our guidelines | ||
| (not just this PR message) | ||
| - [ ] [ ] There are appropriate tests covering any new functionality | ||
| - [ ] [ ] The documentation has been updated or is unnecessary | ||
| - [ ] [ ] The changes have been verified | ||
| - [ ] [ ] New dependencies are appropriate or there were no changes | ||
|
|
||
| - [ ] The commit message is clear and follows our guidelines | ||
| (not just this pull request message) | ||
| - [ ] There are appropriate tests covering any new functionality | ||
| - [ ] The documentation has been updated or is unnecessary | ||
| - [ ] The changes have been verified | ||
| - [ ] New dependencies are appropriate or there were no changes |