Skip to content

Commit

Permalink
Merge pull request #421 from aldros-ffxi/feature/gnb-extras
Browse files Browse the repository at this point in the history
Add a few extras to single target for GNB
  • Loading branch information
MKhayle authored Aug 12, 2024
2 parents 2cf4602 + d77256a commit 6577f2d
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 1 deletion.
24 changes: 23 additions & 1 deletion XIVComboExpanded/Combos/GNB.cs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.Data.Common;
using Dalamud.Game.ClientState.JobGauge.Types;
using System;

Expand Down Expand Up @@ -165,11 +166,33 @@ protected override uint Invoke(uint actionID, uint lastComboMove, float comboTim
{
if (actionID == GNB.BurstStrike)
{
if (IsEnabled(CustomComboPreset.GunbreakerBurstStrikeDangerZone))
{
if (level >= GNB.Levels.DangerZone && IsCooldownUsable(GNB.DangerZone))
return OriginalHook(GNB.DangerZone);
}

if (IsEnabled(CustomComboPreset.GunbreakerBurstStrikeCont))
{
if (level >= GNB.Levels.EnhancedContinuation && HasEffect(GNB.Buffs.ReadyToBlast))
return GNB.Hypervelocity;
}

if (IsEnabled(CustomComboPreset.GunbreakerBurstStrikeGnashingFang))
{
if (level >= GNB.Levels.GnashingFang)
{
var gauge = GetJobGauge<GNBGauge>();
if (IsEnabled(CustomComboPreset.GunbreakerGnashingFangCont) &&
(HasEffect(GNB.Buffs.ReadyToRip) ||
HasEffect(GNB.Buffs.ReadyToTear) ||
HasEffect(GNB.Buffs.ReadyToGouge)))
return OriginalHook(GNB.Continuation);
if ((IsCooldownUsable(GNB.GnashingFang) && gauge.Ammo > 0) || !IsOriginal(GNB.GnashingFang))
return OriginalHook(GNB.GnashingFang);

}
}
}

if (actionID == GNB.FatedCircle)
Expand Down Expand Up @@ -252,7 +275,6 @@ protected override uint Invoke(uint actionID, uint lastComboMove, float comboTim
return GNB.FatedBrand;
}


if (level >= GNB.Levels.FatedCircle && gauge.Ammo == maxAmmo)
return GNB.FatedCircle;
}
Expand Down
12 changes: 12 additions & 0 deletions XIVComboExpanded/CustomComboPreset.cs
Original file line number Diff line number Diff line change
Expand Up @@ -833,6 +833,18 @@ public enum CustomComboPreset
[CustomComboInfo("Gnashing Fang Continuation", "Replace Gnashing Fang with Continuation moves when appropriate.", GNB.JobID)]
GunbreakerGnashingFangCont = 3702,

[SectionCombo("Single Target")]
[IconsCombo([GNB.BurstStrike, UTL.ArrowLeft, GNB.GnashingFang])]
[AccessibilityCustomCombo]
[CustomComboInfo("Burst Strike into Gnashing Fang", "Replace Burst Strike with Gnashing Fang if available.", GNB.JobID)]
GunbreakerBurstStrikeGnashingFang = 3724,

[SectionCombo("Single Target")]
[IconsCombo([GNB.BurstStrike, UTL.ArrowLeft, GNB.DangerZone])]
[AccessibilityCustomCombo]
[CustomComboInfo("Burst Strike into Danger Zone", "Replace Burst Strike with Danger Zone if available.", GNB.JobID)]
GunbreakerBurstStrikeDangerZone = 3725,

[SectionCombo("Area of Effect")]
[IconsCombo([GNB.DemonSlaughter, UTL.ArrowLeft, GNB.DemonSlice])]
[CustomComboInfo("Demon Slaughter Combo", "Replace Demon Slaughter with its combo chain.", GNB.JobID)]
Expand Down

0 comments on commit 6577f2d

Please sign in to comment.