-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get things in place for a color scheme setting. #629
base: master
Are you sure you want to change the base?
Conversation
I think this is close if I knew how to create a database migration. :)
@heyitsal @spaceninja What do you think? Should this be a "color scheme" account setting, or should it be a "Theme" account setting? I think the latter allows for eventual alternate themes beyond light/dark/"default" selections. |
@trey In addition to creating a database migration, you'll need to update the Feel free to document this for the project README file. I mention how to apply any migrations against a local instance, but now how to develop one. |
I said "color scheme" in the issue, but I don't have any particularly strong feelings about it. I'd be fine with calling it "Theme" |
@@ -1,5 +1,5 @@ | |||
<!doctype html> | |||
<html> | |||
<html{% if current_user_object and current_user_object != 'match' %} class="{{ current_user_object.color_scheme }}"{% end %}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know Python, but think this is what you mean?
<html{% if current_user_object and current_user_object != 'match' %} class="{{ current_user_object.color_scheme }}"{% end %}> | |
<html{% if current_user_object and current_user_object.color_scheme != 'match' %} class="{{ current_user_object.color_scheme }}"{% end %}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this!
The macOS setting is labelled "Appearance". |
Co-authored-by: Scott Vandehey <fake-scott@spaceninja.com>
Co-authored-by: Scott Vandehey <fake-scott@spaceninja.com>
I think this is close if I knew how to create a database migration. :)
Issue #627