Individual locks for settings #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because all locks should be set anew during mods queue or campaign load as per the requirements of the currently used mods.
LordMidas
force-pushed
the
individual-locks-for-settings
branch
from
5174c43 to
cd0f5a7
Compare
This also deprecates the `lock` function.
LordMidas
force-pushed
the
individual-locks-for-settings
branch
from
cd0f5a7 to
a501c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lockfunction is deprecated, backwards compatible support for it is maintained via a legacy lock id.requireSettingValueand/oraddLock. Serializing the locked state leads to unintended behavior when mods are added/removed.Request: We need to add functionality, so that after "Saving" and/or "Applying" the settings - we run the requiredSettingValues check (just like we do on campaign load - see #278). And if any setting couldn't be changed to a value required by the on-change callbacks or now has a value that violates required setting values, we should throw a popup/notification to notify the user.