Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add utility function for adding info for new entities #315

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

LordMidas
Copy link
Member

No description provided.

@LordMidas LordMidas added this to the 1.3.0 milestone Sep 19, 2023
@LordMidas LordMidas force-pushed the feat-utility-function-for-adding-entities branch from 7c8d8e2 to 3045639 Compare September 21, 2023 08:19
@LordMidas LordMidas changed the base branch from main to development September 23, 2023 07:47
msu/utils/entities.nut Outdated Show resolved Hide resolved
@Darxo
Copy link

Darxo commented Nov 24, 2023

I suggest a second function that accepts an array of EntityInfo.
That will make adding a dozen entities at a time look cleaner in the code of mods

msu/utils/entities.nut Outdated Show resolved Hide resolved
@LordMidas
Copy link
Member Author

Upon gaining more experience with adding new entities, I have gained more insight that leads to me to think that this PR is not enough. Namely EntityType is only a thing to count entities and get their names in vanilla. So we need to handle them separately from Troops which are actual units that spawn on the map. So I'll think more on this PR and come up with better solutions.

@Enduriel
Copy link
Member

Enduriel commented Dec 1, 2023

In that case let's postpone

@LordMidas LordMidas modified the milestones: 1.3.0, 1.4.0 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants