Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add create to skill and remove contains check from hookTree #411

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

LordMidas
Copy link
Member

The contains check will cause leaf classes which do not have create defined to not be properly hooked by our hookTree. The solution to this is to add create directly to the base skill class and then hookTree it.

The contains check will cause leaf classes which do not have `create` defined to not be properly hooked by our hookTree. The solution to this is to add `create` directly to the base `skill` class and then hookTree it.
@LordMidas LordMidas requested review from TaroEld and Enduriel August 29, 2024 04:58
@Suor
Copy link
Contributor

Suor commented Sep 2, 2024

Will break mods that old style loop parent up until there is no create, theoretically.

Practically the Spin skill from a bug does have create().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants