Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checker improvements #429

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

TaroEld
Copy link
Member

@TaroEld TaroEld commented Sep 28, 2024

Check the commits

Copy link
Member

@Enduriel Enduriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the debug stuff which we haven't included in the main repo historically, lgtm

Comment on lines +127 to +184

function __addDebugModVersions(_modInfos)
{
_modInfos["A"] <- {
UpdateInfo = {
name = "Test_A_NEW",
currentVersion = "1.2.3",
availableVersion = "1.2.2",
updateType = "PATCH",
changes = @"# H1
## H2
### H3
#### H4
##### H5",
sources = {},
isNew = true
}};
_modInfos["B"] <- {
UpdateInfo = {
name = "Test_B",
currentVersion = "1.2.3",
availableVersion = "1.2.2",
updateType = "MAJOR",
changes = "",
sources = {},
isNew = false
}};
_modInfos["C"] <- {
UpdateInfo = {
name = "Test_C_NEW",
currentVersion = "1.2.3",
availableVersion = "1.2.2",
updateType = "MINOR",
changes = "",
sources = {},
isNew = true
}};
_modInfos["D"] <- {
UpdateInfo = {
name = "Test_D",
currentVersion = "1.2.3",
availableVersion = "1.2.2",
updateType = "MINOR",
changes = "",
sources = {},
isNew = false
}};
_modInfos["E"] <- {
UpdateInfo = {
name = "Test_E_NEW",
currentVersion = "1.2.3",
availableVersion = "1.2.2",
updateType = "MINOR",
changes = "",
sources = {},
isNew = true
}};
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we should keep tests in here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants