Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new onHired and onOtherPlayerHired events for skills #434

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Darxo
Copy link

@Darxo Darxo commented Oct 6, 2024

onHired is an event already present in Vanilla but only in the player.nut and for origins.
Skills however can't react to the hiring of someone.

This PR proposes two new events for skills:

// This event is triggered once for every skill of a player character directly after the onHired event of that player class is triggered
function onHired()

// This event is triggered once for every skill of every other character in the player roster after the onHired event of a player class is triggered
function onOtherPlayerHired( _otherCharacter )

Possible Use Cases

onHired

  • Certain backgrounds can apply mood buff/debuff on hiring, depending on what other backgrounds are already present in the player party
  • Some traits might act as a wildcard/unrevelaed at first (despite trying out) and only transform into a real trait after hiring

onOtherPlayerHired

  • Certain backgrounds might cause a brother to get a positive/negative mood when you hire a certain background
  • Certain backgrounds/perks could grant a bonus to every new recruit (e.g. free perk/stats)

@Darxo Darxo force-pushed the feat-new-skill-events branch from aca51fe to 74f8035 Compare October 6, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant