New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InjectMonsterAtlasResolution - not so dynamic at all + uses const addresses, so unusable for JP #79

Open

1 of 2 tasks

MaKiPL opened this issue Aug 27, 2024 · 0 comments

Assignees

Labels

BUG REPORT coming in next release

Owner

MaKiPL commented Aug 27, 2024 •

edited

Loading

texture.h:28

inline constexpr DWORD DEFAULT_MONSTER_ATLAS_TEX_RESOLUTION = 0x180;

texturepatch_v2_battleHooks.cpp:73

void InjectMonsterAtlasResolution(const DWORD monsterTexResolution)
{
	OutputDebug("InjectMonsterAtlasResolution::Injecting atlas resolution of: %d\n", monsterTexResolution);
	InjectDWORD(IMAGE_BASE + 0x1606D9D+6, monsterTexResolution*2);
	InjectDWORD(IMAGE_BASE + 0x1606DAE+6, monsterTexResolution*2);
	InjectWORD(IMAGE_BASE + 0x16051D1+1, static_cast<WORD>(monsterTexResolution));
}

1. It uses constant addresses without caring for JP version
2. The const 0x180 works in most cases, but breaks for groups of monsters. The resolution should be dynamic

MaKiPL added the BUG REPORT label

MaKiPL self-assigned this

MaKiPL added the coming in next release label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment