Refactor Controllers

Maestro-ESEO · Jan 22, 2024 · 5971b86 · 5971b86
1 parent 7cfac05
commit 5971b86
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 12 deletions.
diff --git a/app/Http/Controllers/CommentController.php b/app/Http/Controllers/CommentController.php
@@ -3,14 +3,12 @@
 namespace App\Http\Controllers;
 
 use App\Utils\AuthUtil;
-use Illuminate\Contracts\View\View;
 use Illuminate\Http\Request;
 use App\Models\Comment;
+
 class CommentController extends Controller {
-    // ...
 
-    public function store(Request $request, $id)
-    {
+    public function store(Request $request, $id) {
         // Validate the request data
         $validatedData = $request->validate([
             'content' => 'required|string|max:500',
@@ -32,4 +30,5 @@ public function store(Request $request, $id)
         // Redirect or return a response
         return redirect()->back();
     }
+
 }
diff --git a/app/Http/Controllers/DashboardController.php b/app/Http/Controllers/DashboardController.php
@@ -2,11 +2,9 @@
 
 namespace App\Http\Controllers;
 
-use Illuminate\Contracts\View\View;
-
 class DashboardController extends Controller {
 
-    public function show(): View {
+    public function show() {
         return view('app.dashboard');
     }
 

diff --git a/app/Http/Controllers/ProjectController.php b/app/Http/Controllers/ProjectController.php
@@ -18,7 +18,7 @@ public function show($id) {
             return redirect()->back();
         }
 
-        $is_admin = app(ProjectController::class)->isAdmin($project->id, $user->id);
+        $is_admin = $this->isAdmin($project->id, $user->id);
 
         return view("app.project", [
             "project" => $project,

diff --git a/app/Http/Controllers/TaskController.php b/app/Http/Controllers/TaskController.php
@@ -5,7 +5,6 @@
 use App\Models\Comment;
 use App\Models\User;
 use App\Models\UserTask;
-use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 use App\Models\Task;
 use App\Models\Project;
@@ -63,8 +62,7 @@ public function updateStatus($id, $status) {
         return redirect()->back();
     }
 
-    public function update(Request $request, $id): string
-    {
+    public function update(Request $request, $id): string {
         $request->validate([
             'name' => 'string|nullable',
             'description' => 'string|nullable',

diff --git a/database/seeders/UserProjectSeeder.php b/database/seeders/UserProjectSeeder.php
@@ -24,6 +24,6 @@ public function run(): void
                 "is_admin" => true
             ]);
         }
-        UserProject::factory()->count(200)->create();
+        UserProject::factory()->count(100)->create();
     }
 }