Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatch logger should let the caller choose broadcast logger #79

Closed
wants to merge 1 commit into from

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 30, 2024

Re: #63 (comment)

This would be a breaking change but I do think it this is the right way to go in the long run and is more obvious/direct in its behavior.

@agrare agrare force-pushed the simplify_cloud_watch_logger branch from 0f03a0a to a5c1fac Compare September 30, 2024 19:27
@Fryguy
Copy link
Member

Fryguy commented Sep 30, 2024

So I was thinking if we're making a breaking change anyway and our application doesn't actually use the cloudwatch logger then why don't we just drop it entirely?

I think we only had this in place for the red hat insights project which was meant to reuse some of our code. Even if they're still reusing it, they can stay on the older version.

@agrare agrare changed the title CloudWatch logger should let the caller chose broadcast logger CloudWatch logger should let the caller choose broadcast logger Oct 2, 2024
@Fryguy
Copy link
Member

Fryguy commented Oct 3, 2024

Closing in favor of #81

@Fryguy Fryguy closed this Oct 3, 2024
@agrare agrare deleted the simplify_cloud_watch_logger branch October 3, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants