Add targeted refresh specs to PowerVS / Fix targeted VM refresh bug #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to update this image in order to provider with "tier1" storage type.
The vcr:power_virtual_servers:setup rake task creats a total of 6 VMs: 4 x VMs with a single (private) network 2 x VMs with one private network and one public network (4x1)+(2x2)=8 total network ports for the VMs
For the PowerVS provider, Flavor maps to system types and SAP profiles. The total available count can fluctuate over time and regions.
In the PowerVS region specs were recorded in, the following 4 storage types are available: $ ibmcloud pi storage-types Listing storage types in region mon01... Type Description tier0 Tier0 - 25 iops/gb tier1 Tier1 - 10 iops/gb tier3 Tier3 - 3 iops/gb tier5k Tier5k - 5000 fixed iops
The recent VCR cassette was recorded using the mon01 region.
jaywcarman
force-pushed
the
powervs_targeted_vm_refresh_specs
branch
from
9f3b1df to
82e6ed7
Compare
jaywcarman
changed the title
agrare
reviewed
Jan 22, 2024
.../manageiq/providers/ibm_cloud/inventory/collector/power_virtual_servers/target_collection.rb
Outdated
Show resolved
Hide resolved
agrare
reviewed
Jan 22, 2024
.../manageiq/providers/ibm_cloud/inventory/collector/power_virtual_servers/target_collection.rb
Outdated
Show resolved
Hide resolved
agrare
reviewed
Jan 22, 2024
.../manageiq/providers/ibm_cloud/inventory/collector/power_virtual_servers/target_collection.rb
Outdated
Show resolved
Hide resolved
The PowerVS instance API does not include a list of snapshots. The only way to generate a list of snapshots that belong to a particule instance is to get all snapshots and filter based on instance ID.
jaywcarman
force-pushed
the
powervs_targeted_vm_refresh_specs
branch
from
82e6ed7 to
a7f1986
Compare
|
Checked commits jaywcarman/manageiq-providers-ibm_cloud@0255308~...a7f1986 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
approved these changes
Jan 23, 2024
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Jan 31, 2024
…pecs Add targeted refresh specs to PowerVS / Fix targeted VM refresh bug (cherry picked from commit 14a1b1d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed duplicate entries in the
advanced_settingstable on an internal MIQ instance. @agrare suggested I add some targeted refresh specs to see if it caught the issue. Looks like there is an issue with duplicate snapshots.