Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case where :credentials column is nil #64

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 12, 2024

If the :credentials column is nil rather than {} as we had been testing with, the resolved_credentials method properly handles this but the update_credentials! method was not and caused the workflow instance run to throw an exception

@agrare agrare added bug Something isn't working quinteros/yes? labels Jan 12, 2024
@miq-bot
Copy link
Member

miq-bot commented Jan 12, 2024

Checked commit agrare@d437be4 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy Fryguy merged commit 41f5cde into ManageIQ:master Jan 12, 2024
3 checks passed
@Fryguy
Copy link
Member

Fryguy commented Jan 12, 2024

Backported to quinteros in commit 1046c12.

commit 1046c124293c0c02c5e749ba7016b303b848f1a3
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Jan 12 10:44:09 2024 -0500

    Merge pull request #64 from agrare/fix_update_credentials_nil
    
    Handle the case where `:credentials` column is `nil`
    
    (cherry picked from commit 41f5cde0d75e3d57833c890698719518008cfb37)

Fryguy added a commit that referenced this pull request Jan 12, 2024
Handle the case where `:credentials` column is `nil`

(cherry picked from commit 41f5cde)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quinteros/backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants