Add the ability to set runner_options in Settings #65
Conversation
| if Rails.env.production? | ||
| options["root"] = Rails.root.join("data/containers/storage").to_s | ||
| else | ||
| options["network"] = "host" | ||
| end | ||
|
|
||
| options.merge!(Settings.ems.ems_workflows.runner_options.podman) |
There was a problem hiding this comment.
NOTE I wanted to merge after our defaults in case someone wanted to override one of these instead of doing options = Settings.ems.... above then setting these defaults
agrare
force-pushed
the
add_runner_options_to_settings
branch
2 times, most recently
from
359a209 to
84504f9
Compare
| :ems_workflows: | ||
| :runner_options: | ||
| :docker: | ||
| :network: host |
There was a problem hiding this comment.
Having a development.yml meant I could move the options["network"] = "host" if Rails.env.development? out of the engine 🎉
There was a problem hiding this comment.
huh. I never saw those implications. that is very cool
agrare
force-pushed
the
add_runner_options_to_settings
branch
from
84504f9 to
d2bbc06
Compare
agrare
force-pushed
the
add_runner_options_to_settings
branch
from
d2bbc06 to
24b779c
Compare
|
Checked commits agrare/manageiq-providers-workflows@119d80c~...24b779c with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
| else | ||
| options["network"] = "host" | ||
| end | ||
| options["root"] = Rails.root.join("data/containers/storage").to_s if Rails.env.production? |
There was a problem hiding this comment.
the development part was so cool that my brain is working overtime to try and do the same thing with production.
Depends on: