Add manageiq user to disk group

[nasark]

Since we run as non-root, this will allow smartstate scans to be run on ISCSI store types

@miq-bot assign @agrare
@miq-bot add_label bug, quinteros/yes?

[Fryguy]

Also, very minor, but for future readers, I wonder if it's easier to use the full option names?

Suggested change

	/usr/sbin/usermod -a -G disk manageiq
	/usr/sbin/usermod --append --groups disk manageiq

[agrare]

We should check what the command does when the user is already part of the group, if it returns a non-zero exit code that will cause the rpm scriptlet to fail

[agrare]

[root@manageiq ~]# groups manageiq
manageiq : manageiq
[root@manageiq ~]# /usr/sbin/usermod --append --groups disk manageiq
[root@manageiq ~]# echo $?
0
[root@manageiq ~]# groups manageiq
manageiq : manageiq disk
[root@manageiq ~]# /usr/sbin/usermod --append --groups disk manageiq
[root@manageiq ~]# echo $?
0

Seems like it returns 0 in either case, might be a good idea to check if it is in the group first though groups manageiq | grep disk >/dev/null 2>&1 || /usr/sbin/usermod ... just so it is more obvious

[miq-bot]

Checked commit nasark@a0da7a8 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

[nasark]

Ready for another pass

[Fryguy]

Backported to quinteros in commit acab9a3.

commit acab9a30c34e093f55ad89bbebd1c0631a7d8eeb
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Tue Jan 9 15:50:13 2024 -0500

    Merge pull request #435 from nasark/add_miq_user_to_disk_group
    
    Add manageiq user to disk group
    
    (cherry picked from commit 658af63fc1f5da6cda4e827d88572ad25a7bd7ca)